Why responding to a code review request matters
There was curious thing in the State of DevOps Report 2023.
Speeding up code reviews is one of the most effective paths to improving software delivery performance. Teams with faster code reviews have 50% higher software delivery performance.
Fast is “lgtm”, right? That isn’t good, right? But the catch is that the response time needs to be fast, not the review itself. Unless you are working on something really difficult, you actually need to drop your work and review the merge request.
Google’s code review standards also mention the code review speed as a big factor in performance.
I also like: “In general, reviewers should favor approving a CL once it is in a state where it definitely improves the overall code health of the system being worked on, even if the CL isn’t perfect.”
Besides response time, never compromise on code review standards.
People who have worked with me know I am not one to have my eye on slack constantly. But knowing this, I will experiment to see if we can make our development process more smoothly by being the best damn quick-to-respond code reviewer. Time to enable those gitlab notifications.